On Thu, Mar 08, 2012 at 10:58:06PM +0100, Stefan Weil wrote: > This patch fixes warnings reported by splint: > > For variables which are packed in a single bit, a signed data type > like 'int' does not make much sense. > > There is no obvious reason why the two values should be packed, > so I removed the packing and changed the data type to bool > because both are used as boolean values. > > v2: > > Some versions of gcc complain after this modification, > for example gcc (Debian 4.4.5-8) 4.4.5): > > ui/vnc-auth-sasl.c: In function ‘vnc_sasl_client_cleanup’: > ui/vnc-auth-sasl.c:34: error: suggest parentheses around assignment used as > truth value > > Obviously, the compiler does not like code which does > bool = unsigned = bool = 0 > > Splitting that code in three statements works. > > Cc: Anthony Liguori <aligu...@us.ibm.com> > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > ui/vnc-auth-sasl.c | 4 +++- > ui/vnc-auth-sasl.h | 4 ++-- > 2 files changed, 5 insertions(+), 3 deletions(-)
Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan