On 2024/02/23 1:56, Peter Maydell wrote:
On Sat, 17 Feb 2024 at 11:19, Akihiko Odaki <akihiko.od...@daynix.com> wrote:

It allows making the window full screen by clicking full screen button
provided by the platform (the left-top green button) and save some code.

Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
---
  ui/cocoa.m | 423 ++++++++++++++++++++++++++++++-------------------------------
  1 file changed, 207 insertions(+), 216 deletions(-)

This is a big patch and I'm having difficulty figuring out what
it's doing. Is it possible to split it up a bit?

Not really. It indeed does a few different things:
1. Removes fullScreenWindow
2. Changes mouse event handling.
3. Changes coordinate calculations.

Unfortunately we have to do these at once because how window is organized affects both of mouse event handling and coordinate calculations.

Regards,
Akihiko Odaki

Reply via email to