>-----Original Message----- >From: Eric Auger <eric.au...@redhat.com> >Subject: Re: [PATCH rfcv2 07/18] vfio/container: Implement >host_iommu_device_init callback in legacy mode > >Hi Zhenzhong, >On 2/1/24 08:28, Zhenzhong Duan wrote: >> This callback will be used to initialize base and public elements >> in IOMMULegacyDevice. >> >> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com> >> --- >> hw/vfio/container.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/hw/vfio/container.c b/hw/vfio/container.c >> index bd25b9fbad..8fafd4b4e5 100644 >> --- a/hw/vfio/container.c >> +++ b/hw/vfio/container.c >> @@ -1120,6 +1120,12 @@ out_single: >> return ret; >> } >> >> +static void vfio_legacy_host_iommu_device_init(VFIODevice *vbasedev) >> +{ >> + host_iommu_base_device_init(&vbasedev->base_hdev, HID_LEGACY, >> + sizeof(IOMMULegacyDevice)); >To me this should allocate a new > > IOMMULegacyDevice and set the VFIODevice base_hdev handle to its base
Sure, will do. Thanks Zhenzhong