On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan <bala...@eik.bme.hu> writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a convention about using underscore or dash in file names? The headers
Thomas added are using - as well as ahci-allwinner.c, only ahci_internal.h has
_ (but there are others elsewhere such as pci_device.h). Maybe we should be
consistent at least within IDE and this series is now a good opportunity for
renaming these headers to match. But it's just a small nit, thanks for picking
this up.
This is one of the many unnecessary inconsistencies we're inflicting on
ourselves.
We have more than 3600 file names containing '-', and more almost 2700
containing '_'. Bizarrely, 68 of them contain both.
I strongly prefer '_' myself.
Zoltan is making a local consistency argument for '-'.
Let's use '-' here.
Fine, patch updated.
