On Mon, Feb 26, 2024 at 05:06:28PM +0800, dinglimin wrote:
> Date: Mon, 26 Feb 2024 17:06:28 +0800
> From: dinglimin <dingli...@cmss.chinamobile.com>
> Subject: [PATCH] semihosting/uaccess.c: Replaced a malloc call with g_malloc
> X-Mailer: git-send-email 2.30.0.windows.2
>
> Signed-off-by: dinglimin <dingli...@cmss.chinamobile.com>
> ---
> semihosting/uaccess.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Also cc Michael and qemu-triv...@nongnu.org.
I understand the simple cleanup can cc qemu-triv...@nongnu.org. ;-)
Reviewed-by: Zhao Liu <zhao1....@intel.com>
>
> diff --git a/semihosting/uaccess.c b/semihosting/uaccess.c
> index dc587d73bc..7788ead9b2 100644
> --- a/semihosting/uaccess.c
> +++ b/semihosting/uaccess.c
> @@ -14,10 +14,10 @@
> void *uaccess_lock_user(CPUArchState *env, target_ulong addr,
> target_ulong len, bool copy)
> {
> - void *p = malloc(len);
> + void *p = g_try_malloc(len);
> if (p && copy) {
> if (cpu_memory_rw_debug(env_cpu(env), addr, p, len, 0)) {
> - free(p);
> + g_free(p);
> p = NULL;
> }
> }
> @@ -87,5 +87,5 @@ void uaccess_unlock_user(CPUArchState *env, void *p,
> if (len) {
> cpu_memory_rw_debug(env_cpu(env), addr, p, len, 1);
> }
> - free(p);
> + g_free(p);
> }
> --
> 2.30.0.windows.2
