On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 13:52, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Most ICH9-related files use the 'ich9_' prefix.
Mention 'AHCI' in the file name.
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
hw/ide/{ich.c => ich9_ahci.c} | 0
That would rather be ahci-ich9.h then analogous to ahci-allwinnet.c maybe?
We can have all ICH9 functions named ich9_foo.c, or all AHCI
implementations named bar_ahci.c. But currently there is no
particular style enforced and we have a mix. I don't mind much.
I think if it's in hw/ide then it should follow conventions used by that
part. (Which did not follow any convention befure but Thomas adding a
bunch of headers using - made it have a convention now.) If it's a variant
of AHCI like the allwinner one then it should be groupped with that and
named accordingly. If it would be together with other ich9 parts then it
could be grouped there or if there wasn't already an example for ahci
variant, but in this case only ahci-ich9 seems consistent within IDE now.
Regsards,
BALATON Zoltan
