> On 27-Feb-2024, at 21:17, Igor Mammedov <imamm...@redhat.com> wrote: > > that will avoid double free if smbios_get_tables() is called > multiple times. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> Maybe we can squash this with patch 10. Other than that, Reviewed-by: Ani Sinha <anisi...@redhat.com> > --- > hw/smbios/smbios.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > index 7c28b5f748..d9ba2072b1 100644 > --- a/hw/smbios/smbios.c > +++ b/hw/smbios/smbios.c > @@ -1052,6 +1052,8 @@ void smbios_get_tables(MachineState *ms, > return; > err_exit: > g_free(smbios_tables); > + smbios_tables = NULL; > + return; > } > > static void save_opt(const char **dest, QemuOpts *opts, const char *name) > -- > 2.39.3 >
- Re: [PATCH 10/19] smbios: handle errors c... Igor Mammedov
- Re: [PATCH 10/19] smbios: handle erro... Ani Sinha
- [PATCH 16/19] smbios: clear smbios_type4_count bef... Igor Mammedov
- [PATCH 07/19] smbios: avoid mangling user provided... Igor Mammedov
- Re: [PATCH 07/19] smbios: avoid mangling user... Ani Sinha
- Re: [PATCH 07/19] smbios: avoid mangling ... Igor Mammedov
- [PATCH 13/19] smbios: extend smbios-entry-point-ty... Igor Mammedov
- Re: [PATCH 13/19] smbios: extend smbios-entry... Markus Armbruster
- Re: [PATCH 00/19] Workaround Windows failing to fi... Michael S. Tsirkin
- [PATCH 11/19] smbios: clear smbios_tables pointer ... Igor Mammedov
- Re: [PATCH 11/19] smbios: clear smbios_tables... Ani Sinha
- Re: [PATCH 11/19] smbios: clear smbios_ta... Igor Mammedov
- [PATCH 06/19] smbios: get rid of smbios_legacy glo... Igor Mammedov
- Re: [PATCH 06/19] smbios: get rid of smbios_l... Ani Sinha
- Re: [PATCH 06/19] smbios: get rid of smbi... Igor Mammedov
- Re: [PATCH 06/19] smbios: get rid of ... Ani Sinha
- Re: [PATCH 06/19] smbios: get rid of smbios_l... Daniel Henrique Barboza
- [PATCH 08/19] smbios: don't check type4 structures... Igor Mammedov
- [PATCH 17/19] tests: acpi/smbios: whitelist expect... Igor Mammedov
- Re: [PATCH 00/19] Workaround Windows failing to fi... Fiona Ebner