On 16.03.2012 20:19, Anthony Liguori wrote: > On 03/15/2012 04:00 PM, Michael Tokarev wrote: >> Similar to >> qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, >> int c, size_t bytes); >> the new prototype is: >> qemu_iovec_from_buf(QEMUIOVector *qiov, size_t offset, >> const void *buf, size_t bytes); >> >> The processing starts at offset bytes within qiov. >> >> This way, we may copy a bounce buffer directly to >> a middle of qiov. >> >> This is exactly the same function as iov_from_buf() from >> iov.c, so use the existing implementation and rename it >> to qemu_iovec_from_buf() to be shorter and to match the >> utility function. >> >> As with utility implementation, we now assert that the >> offset is inside actual iovec. Nothing changed for >> current callers, because `offset' parameter is new. >> >> While at it, stop using "bounce-qiov" in block/qcow2.c >> and copy decrypted data directly from cluster_data >> instead of recreating a temp qiov for doing that >> (Cc'ing kwolf for this change). >> >> Signed-off-by: Michael Tokarev<m...@tls.msk.ru> >> Cc: Kevin Wolf<kw...@redhat.com> > > Kevin, please Ack.
Kevin already reviewed the (previous version which hasn't changed in the block layer) patch: http://thread.gmane.org/gmane.comp.emulators.qemu/140817/focus=141013 but since he didn't include any Signed-off-by/Reviewed-by I left it as-is. Thanks, /mjt
