On 3/8/24 09:09, Jason Wang wrote:
On Tue, Mar 5, 2024 at 6:07 PM Laurent Vivier <lviv...@redhat.com> wrote:
On 2/1/24 06:45, Jason Wang wrote:
On Wed, Jan 24, 2024 at 6:40 PM Laurent Vivier <lviv...@redhat.com> wrote:
On resume e1000e_vm_state_change() always calls e1000e_autoneg_resume()
that sets link_down to false, and thus activates the link even
if we have disabled it.
The problem can be reproduced starting qemu in paused state (-S) and
then set the link to down. When we resume the machine the link appears
to be up.
Reproducer:
# qemu-system-x86_64 ... -device e1000e,netdev=netdev0,id=net0 -S
{"execute": "qmp_capabilities" }
{"execute": "set_link", "arguments": {"name": "net0", "up": false}}
{"execute": "cont" }
To fix the problem, merge the content of e1000e_vm_state_change()
into e1000e_core_post_load() as e1000 does.
Buglink: https://issues.redhat.com/browse/RHEL-21867
Fixes: 6f3fbe4ed06a ("net: Introduce e1000e device emulation")
Suggested-by: Akihiko Odaki <akihiko.od...@daynix.com>
Signed-off-by: Laurent Vivier <lviv...@redhat.com>
---
I've queued this.
Ping?
Thanks,
Laurent
This fail CI at:
https://gitlab.com/jasowang/qemu/-/jobs/6348725267
It looks to me we can safely drop e1000e_autoneg_pause()?
Thanks
Yes, I'm going to send a new version of the patch.
Thanks,
Laurent
