On 9/3/24 14:40, Bernhard Beschow wrote:
PAM_REGIONS_COUNT being 13 seems to be Intel-specific. There are VIA 82cXX
northbridges having only 10, for example. Communicate this by having
northbridge-specific constants.

Signed-off-by: Bernhard Beschow <shen...@gmail.com>

--

Do we need the constants or can we omit them, given they're just used once?

We don't need but prefer, since the definition is self-explicit
and we don't have to lookup datasheet for magic value.

---
  include/hw/pci-host/i440fx.h | 4 +++-
  include/hw/pci-host/pam.h    | 2 --
  include/hw/pci-host/q35.h    | 4 +++-
  hw/pci-host/q35.c            | 2 +-
  4 files changed, 7 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to