On 3/11/24 04:38, Zhao Liu wrote:
From: Zhao Liu <zhao1....@intel.com>As the comment in qapi/error, passing @errp to error_prepend() requires ERRP_GUARD(): * = Why, when and how to use ERRP_GUARD() = * * Without ERRP_GUARD(), use of the @errp parameter is restricted: ... * - It should not be passed to error_prepend(), error_vprepend() or * error_append_hint(), because that doesn't work with &error_fatal. * ERRP_GUARD() lifts these restrictions. * * To use ERRP_GUARD(), add it right at the beginning of the function. * @errp can then be used without worrying about the argument being * NULL or &error_fatal. ERRP_GUARD() could avoid the case when @errp is &error_fatal, the user can't see this additional information, because exit() happens in error_setg earlier than information is added [1]. In target/s390x/cpu_models.c, there are 2 functions passing @errp to error_prepend() without ERRP_GUARD(): - check_compatibility() - s390_realize_cpu_model() Though both their @errp parameters point to their callers' local @err virables and don't cause the issue as [1] said, to follow the requirement of @errp, also add missing ERRP_GUARD() at their beginning. [1]: Issue description in the commit message of commit ae7c80a7bd73 ("error: New macro ERRP_GUARD()"). Cc: David Hildenbrand <da...@redhat.com> Cc: Thomas Huth <th...@redhat.com> Cc: Richard Henderson <richard.hender...@linaro.org> Cc: Ilya Leoshkevich <i...@linux.ibm.com> Cc: qemu-s3...@nongnu.org Signed-off-by: Zhao Liu <zhao1....@intel.com> ---
Reviewed-by: Cédric Le Goater <c...@kaod.org> Thanks, C.
