On Tue Mar 12, 2024 at 9:12 PM AEST, Pavel Dovgalyuk wrote: > On 12.03.2024 14:05, Nicholas Piggin wrote: > > On Tue Mar 12, 2024 at 7:09 PM AEST, Pavel Dovgalyuk wrote: > >> This won't work, as needed. Announce timer can't be enabled, because > >> it is set in post_load function. Therefore announce callbacks break > >> the replay, when virtio-net is used with snapshots. > > > > I see. Is that somehow marked as being incompatible with rr? > > Here's the prior discussion on it: > https://lore.kernel.org/qemu-devel/8735ovx0zd....@linaro.org/t/
Actually I don't know if it's so simple. If VIRTIO_NET_F_GUEST_ANNOUNCE is clear then AFAIKS it sends a RARP packet instead. Also the timer can be triggered for other reasons than migration. Not quite sure how that all fits together. I guess record/replay would just have to disable it entirely. We could support it if we had a ANNOUNCE event I guess. Thanks, Nick
