On Wed, Mar 20, 2024 at 09:58:40AM +0100, Paolo Bonzini wrote: > On 3/12/24 23:27, Michael S. Tsirkin wrote: > > diff --git a/include/standard-headers/linux/virtio_pci.h > > b/include/standard-headers/linux/virtio_pci.h > > index 3e2bc2c97e..86733278ba 100644 > > --- a/include/standard-headers/linux/virtio_pci.h > > +++ b/include/standard-headers/linux/virtio_pci.h > > @@ -221,6 +221,13 @@ struct virtio_pci_cfg_cap { > > #define VIRTIO_PCI_COMMON_ADM_Q_IDX 60 > > #define VIRTIO_PCI_COMMON_ADM_Q_NUM 62 > > +#define LM_LOGGING_CTRL 0 > > +#define LM_BASE_ADDR_LOW 4 > > +#define LM_BASE_ADDR_HIGH 8 > > +#define LM_END_ADDR_LOW 12 > > +#define LM_END_ADDR_HIGH 16 > > +#define LM_VRING_STATE_OFFSET 0x20 > > I cannot find these constants in upstream Linux (what will be 6.9). Is there > a tree that defines these constants, or should they be moved to > include/hw/virtio/vdpa-dev.h (or something like that)? > > Thanks, > > Paolo
They should be moved. If the contributor doesn't do that soon I will revert the change. Thanks! -- MST