On 3/21/24 18:15, Philippe Mathieu-Daudé wrote:
On 21/3/24 17:01, Cédric Le Goater wrote:
Coverity detected an "Integer handling" issue with the pin value :
In expression "state >> pin", right shifting "state" by more than 7
bits always yields zero. The shift amount, "pin", is as much as 8.
In practice, this should not happen because the properties "pin8" and
above are not created. Nevertheless, fix the range to avoid this warning.
Fixes: CID 1534917
Fixes: de0c7d543bca ("misc: Add a pca9554 GPIO device model")
Cc: Glenn Miles <mil...@linux.vnet.ibm.com>
Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
hw/misc/pca9554.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Isn't it the one Peter fixed in
https://lore.kernel.org/qemu-devel/20240312183810.557768-5-peter.mayd...@linaro.org/?
Oh yes. I missed it. Hopefully, they are similar. Let's keep Peter's.
However, what I would like to do as a follow-up is to move the
hw/misc/pca955* models under hw/gpio/. Is it something we can do
for 9.0 ?
Thanks,
C.
