On Sun, 17 Mar 2024 at 10:41, Arnaud Minier <arnaud.min...@telecom-paris.fr> wrote: > > Create different types for the USART, UART and LPUART of the STM32L4x5 > to deduplicate code and enable the implementation of different > behaviors depending on the type. > > Signed-off-by: Arnaud Minier <arnaud.min...@telecom-paris.fr> > Signed-off-by: Inès Varhol <ines.var...@telecom-paris.fr> > --- > hw/char/stm32l4x5_usart.c | 113 +++++++++++++++++++----------- > include/hw/char/stm32l4x5_usart.h | 21 +++++- > 2 files changed, 92 insertions(+), 42 deletions(-) > > diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c > index b56fee5b3a..f58bd56875 100644 > --- a/hw/char/stm32l4x5_usart.c > +++ b/hw/char/stm32l4x5_usart.c > @@ -154,9 +154,9 @@ REG32(RDR, 0x24) > REG32(TDR, 0x28) > FIELD(TDR, TDR, 0, 8) > > -static void stm32l4x5_usart_reset_hold(Object *obj) > +static void stm32l4x5_usart_base_reset_hold(Object *obj) > { > - STM32L4X5UsartState *s = STM32L4X5_USART(obj); > + Stm32l4x5UsartBaseState *s = STM32L4X5_USART_BASE(obj);
Could you avoid this kind of "add function/type/etc in one patch and then rename it in a following patch", please? Give things the right name from the start. This probably looks something like "squash this patch into the previous one" in practice. thanks -- PMM