On Tue, 12 Mar 2024 at 08:32, Xiong Yining <xiongyining1...@phytium.com.cn> wrote: > > Enable CPU cluster support on SbsaQemu platform, so that users can > specify a 4-level CPU hierarchy sockets/clusters/cores/threads. And this > topology can be passed to the firmware through DT cpu-map. > > Changes in v2: > - put this code before sbsa_fdt_add_gic_node(). > > xiongyining1480 (2): > hw/arm/sbsa-ref:Enable CPU cluster on ARM sbsa machine > hw/arm/sbsa-ref: Add cpu-map to device tree
Thanks for these patches. I think we should squash the two patches together into one, because the first patch is only a single line, and also because we shouldn't say that the machine supports cluster topology until it actually does by putting the information into the device tree. There's no rush, because we're now in softfreeze for 9.0, so these will have to wait until 9.0 is released (in about a month's time). I'm also a bit confused by the Reviewed-by: tag from Marcin on patch 2, because I can't see that in my mail archives of the discussion on version 1 of this patchset, only a Tested-by. Marcin, are you OK with these patches? Also, is this change to the DTB something that would require an increase in the sbsa-ref platform version number, or not? Should we adjust the documentation in docs/system/arm/sbsa.rst to mention that the DTB might have cluster topology information? thanks -- PMM
