Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

[Philippe Mathieu-Daudé]

On 22/3/24 18:46, aidan_le...@selinc.com wrote:

From: Aidan Leuck <aidan_le...@selinc.com>

Signed-off-by: Aidan Leuck <aidan_le...@selinc.com>
---
  qga/commands-windows-ssh.c | 791 +++++++++++++++++++++++++++++++++++++

Huge file, I'm skipping it.

  qga/commands-windows-ssh.h |  26 ++
  qga/meson.build            |   5 +-
  qga/qapi-schema.json       |  17 +-
  4 files changed, 828 insertions(+), 11 deletions(-)
  create mode 100644 qga/commands-windows-ssh.c
  create mode 100644 qga/commands-windows-ssh.h

diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index 9554b566a7..a64a6d91cf 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1562,9 +1562,8 @@
  { 'struct': 'GuestAuthorizedKeys',
    'data': {
        'keys': ['str']
-  },
-  'if': 'CONFIG_POSIX' }
-

For Windows you have to check the CONFIG_WIN32 definition,
so you want:

  'if': { 'any': [ 'CONFIG_POSIX',
                   'CONFIG_WIN32' ] },

+  }
+}

##

  # @guest-ssh-get-authorized-keys:
@@ -1580,8 +1579,8 @@
  ##
  { 'command': 'guest-ssh-get-authorized-keys',
    'data': { 'username': 'str' },
-  'returns': 'GuestAuthorizedKeys',
-  'if': 'CONFIG_POSIX' }
+  'returns': 'GuestAuthorizedKeys'
+}

##

  # @guest-ssh-add-authorized-keys:
@@ -1599,8 +1598,8 @@
  # Since: 5.2
  ##
  { 'command': 'guest-ssh-add-authorized-keys',
-  'data': { 'username': 'str', 'keys': ['str'], '*reset': 'bool' },
-  'if': 'CONFIG_POSIX' }
+  'data': { 'username': 'str', 'keys': ['str'], '*reset': 'bool' }
+}

##

  # @guest-ssh-remove-authorized-keys:
@@ -1617,8 +1616,8 @@
  # Since: 5.2
  ##
  { 'command': 'guest-ssh-remove-authorized-keys',
-  'data': { 'username': 'str', 'keys': ['str'] },
-  'if': 'CONFIG_POSIX' }
+  'data': { 'username': 'str', 'keys': ['str'] }
+}

##

  # @GuestDiskStats: