From: Igor Mammedov <imamm...@redhat.com>
QEMU build fails with
hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'
when it's built with only 'microvm' enabled i.e. with config patch
+++ b/configs/devices/i386-softmmu/default.mak
@@ -26,7 +26,7 @@
# Boards:
#
-CONFIG_ISAPC=y
-CONFIG_I440FX=y
-CONFIG_Q35=y
+CONFIG_ISAPC=n
+CONFIG_I440FX=n
+CONFIG_Q35=n
It happens because I've fogotten/lost smbios_get_table_legacy() stub.
Fix it by adding missing stub as Philippe suggested.
Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine"
Reported-by: Michael Tokarev <m...@tls.msk.ru>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
Signed-off-by: Igor Mammedov <imamm...@redhat.com>
Message-ID: <20240326122630.85989-1-imamm...@redhat.com>
Tested-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
hw/smbios/smbios_legacy_stub.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hw/smbios/smbios_legacy_stub.c b/hw/smbios/smbios_legacy_stub.c
index f29b15316c..7d593dca98 100644
--- a/hw/smbios/smbios_legacy_stub.c
+++ b/hw/smbios/smbios_legacy_stub.c
@@ -13,3 +13,8 @@
void smbios_add_usr_blob_size(size_t size)
{
}
+
+uint8_t *smbios_get_table_legacy(size_t *length, Error **errp)
+{
+ g_assert_not_reached();
+}
--
2.41.0
