Hi Paolo,
On Mon, Mar 25, 2024 at 03:14:21PM +0100, Paolo Bonzini wrote:
> Date: Mon, 25 Mar 2024 15:14:21 +0100
> From: Paolo Bonzini <pbonz...@redhat.com>
> Subject: [PATCH for-9.1 v5 2/3] target/i386: add guest-phys-bits cpu
> property
> X-Mailer: git-send-email 2.44.0
>
> From: Gerd Hoffmann <kra...@redhat.com>
>
> Allows to set guest-phys-bits (cpuid leaf 80000008, eax[23:16])
> via -cpu $model,guest-phys-bits=$nr.
>
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> Message-ID: <20240318155336.156197-3-kra...@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> v4->v5:
> - move here all non-KVM parts
> - add compat property and support for special value "-1" (accelerator
> defines value)
>
> target/i386/cpu.h | 1 +
> hw/i386/pc.c | 4 +++-
> target/i386/cpu.c | 22 ++++++++++++++++++++++
> 3 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index 6b057380791..83e47358451 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -2026,6 +2026,7 @@ struct ArchCPU {
>
> /* Number of physical address bits supported */
> uint32_t phys_bits;
> + uint32_t guest_phys_bits;
Maybe here it deserves a comment, just as most any other fields...what
about copying commit message of patch 3 like:
/*
* Number of guest physical address bits supported. Usually this is
* identical to host physical address bits. With NPT or EPT being used
* this might be restricted to 48 (max 4-level paging address space
* size) even if the host cpu supports more physical address bits.
*/
Otherwise,
Reviewed-by: Zhao Liu <zhao1....@intel.com>
