Hi Daniel, My apologies for all the missed feedback in v2. I'll be more organized for my next iteration.
For this specific comment below, I would like to make sure I'm testing the right way. > > diff --git a/meson.build b/meson.build > > index b375248a7614..376da49b60ab 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -4052,6 +4052,11 @@ if have_tools > > dependencies: [authz, crypto, io, qom, qemuutil, > > libcap_ng, mpathpersist], > > install: true) > > + > > + executable('qemu-vmsr-helper', files('tools/i386/qemu-vmsr-helper.c'), > > + dependencies: [authz, crypto, io, qom, qemuutil, > > + libcap_ng, mpathpersist], > > + install: true) > > endif > > Missed feedback from v2 saying this must /only/ be built > on x86 architectures. It fails to build on others due > to the ASM usage eg > > https://gitlab.com/berrange/qemu/-/jobs/6445384073 > To recreate your build system, I need to, for example, compile with the following configuration for arm64 (aarch64): ../configure --enable-werror --disable-docs --enable-fdt=system --disable-user --cross-prefix=aarch64-linux-gnu- --target-list-exclude="arm-softmmu cris-softmmu i386-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu mips64-softmmu ppc-softmmu riscv32-softmmu sh4-softmmu sparc-softmmu xtensa-softmmu" This is cross-compiling on x86 right? Because on my laptop I've got the following error: WARNING: unrecognized host CPU, proceeding with 'uname -m' output 'x86_64' python determined to be '/usr/bin/python3' python version: Python 3.12.2 mkvenv: Creating non-isolated virtual environment at 'pyvenv' mkvenv: checking for meson>=0.63.0 ERROR: Unrecognized host OS (uname -s reports 'Linux') It looks like it wants to build natively on aarch64. Maybe I need to create a VM with aarch64 Debian and compile natively? Might take a long time but I'm not sure this is the best way. Regards, Anthony