On Sun, 21 Jan 2024 21:50:00 -0500 Hyeonggon Yoo <42.hye...@gmail.com> wrote:
> On Tue, Jan 9, 2024 at 12:54 PM Jonathan Cameron > <jonathan.came...@huawei.com> wrote: > > > > On Fri, 22 Dec 2023 18:00:50 +0900 > > Hyeonggon Yoo <42.hye...@gmail.com> wrote: > > > > > The spec states that reads/writes should have no effect and a part of > > > commands should be ignored when the media is disabled, not when the > > > sanitize command is running.qq > > > > > > Introduce cxl_dev_media_disabled() to check if the media is disabled and > > > replace sanitize_running() with it. > > > > > > Make sure that the media has been correctly disabled during sanitation > > > by adding an assert to __toggle_media(). Now, enabling when already > > > enabled or vice versa results in an assert() failure. > > > > > > Suggested-by: Davidlohr Bueso <d...@stgolabs.net> > > > Signed-off-by: Hyeonggon Yoo <42.hye...@gmail.com> > > > > This applies to > > > > hw/cxl: Add get scan media capabilities cmd support. > > > > Should I just squash it with that patch in my tree? > > For now I'm holding it immediately on top of that, but I'm not keen to > > send messy code upstream unless there is a good reason to retain the > > history. > > Oh, while the diff looks like the patch touches scan_media_running(), it's > not. > > The proper Fixes: tag will be: > Fixes: d77176724422 ("hw/cxl: Add support for device sanitation") > > > If you are doing this sort of fix series in future, please call out > > what they fix explicitly. Can't use fixes tags as the commit ids > > are unstable, but can mention the patch to make my life easier! > > Okay, next time I will either add the Fixes tag or add a comment on > what it fixes. > > By the way I guess your latest, public branch is still cxl-2023-11-02, right? > https://gitlab.com/jic23/qemu/-/tree/cxl-2023-11-02 > > I assume you adjusted my v2 series, but please let me know if you prefer > sending v3 against your latest tree. > > Thanks, > Hyeonggon Side note, in it's current form this breaks the switch-cci support in upstream QEMU. I've finally gotten back to getting ready to look at MMPT support and ran into a crash as a result. Needs protection with checked object_dynamic_cast() to make sure we have a type3 device. I'll update the patch in my tree. Thanks, Jonathan >