2012/3/13 Lluís Vilanova <vilan...@ac.upc.edu>: > The first patch in the series (by Harsh Prateek) is a rewrite of the tracetool > shell script in python, which is easier to handle given the current complexity > of the script. > > The following patches (by Lluís Vilanova) add a series of random code cleanups > and generalizations. > > Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> > --- > > NOTE: This series contains the first 11 patches from Harsh's v5 series, which > are the ones required for the language conversion. > > Version History: > > v6: > - Rebase on cb72b758 from master. > - Revive documentation whitespace deletions. > - Split off this series the patches regarding the new simpletrace trace > format. > > v5: > - trace/simple.c: Introduced new struct TraceRecordHeader for log header > consistency > - Addressed Stefan's review comments for scripts/simpletrace.py > > v4: > - Addressed Stefan's review comments for tracetool, trace/simple.* > - Adressed Fast producer, Slow consumer problem > - Isolated tracetool python conversion patch from simpletrace v2 changes. > - Included improvements and fixes from Lluis Vilanova > TODO: Update simpletrace.py for simpletrace v2 log format. > > v3: > - Added support for LTTng ust trace backend in tracetool.py > > v2: > - Updated tracetool.py to support nop, stderr, dtrace backend > > v1: > - Working protoype with tracetool.py converted only for simpletrace backend > > Harsh Prateek Bora (1): > Converting tracetool.sh to tracetool.py > > Lluís Vilanova (11): > trace: [tracetool] Remove unused 'sizestr' attribute in 'Event' > trace: [tracetool] Do not rebuild event list in backend code > trace: [tracetool] Simplify event line parsing > trace: [tracetool] Do not precompute the event number > trace: [tracetool] Add support for event properties > trace: [tracetool] Process the "disable" event property > trace: [tracetool] Rewrite event argument parsing > trace: [tracetool] Make format-specific code optional and with access to > events > trace: [tracetool] Automatically establish available backends and formats > trace: Provide a per-event status define for conditional compilation > trace: [tracetool] Add error-reporting functions > > > Makefile.objs | 6 > Makefile.target | 13 + > configure | 7 - > scripts/tracetool | 648 > -------------------------------------------------- > scripts/tracetool.py | 588 +++++++++++++++++++++++++++++++++++++++++++++ > 5 files changed, 602 insertions(+), 660 deletions(-) > delete mode 100755 scripts/tracetool > create mode 100755 scripts/tracetool.py
Looks very close. I diffed the tracetool output for all backends and verified that there is no semantic difference. The only real point I want to reach agreement with you on is how to consolidate formats/backends. I left a reply on that patch because I prefer an alternative to the decorators approach. Stefan
