On 8/4/24 17:53, Paolo Bonzini wrote:
Since the USB stubs are needed exactly when the Kconfig symbols are not
enabled, they can be placed in hw/usb/ and conditionalized on CONFIG_USB.

Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
  stubs/usb-dev-stub.c => hw/usb/bus-stub.c | 0
  hw/usb/meson.build                        | 2 +-
  stubs/meson.build                         | 1 -
  3 files changed, 1 insertion(+), 2 deletions(-)
  rename stubs/usb-dev-stub.c => hw/usb/bus-stub.c (100%)

diff --git a/hw/usb/meson.build b/hw/usb/meson.build
index aac3bb35f27..23f7f7acb50 100644
--- a/hw/usb/meson.build
+++ b/hw/usb/meson.build
@@ -9,7 +9,7 @@ system_ss.add(when: 'CONFIG_USB', if_true: files(
    'desc-msos.c',
    'libhw.c',
    'pcap.c',
-))
+), if_false: files('bus-stub.c'))

I like it because the stub is restricted to the
subsystem. Possibly easing maintenance.

diff --git a/stubs/meson.build b/stubs/meson.build

-  stub_ss.add(files('usb-dev-stub.c'))

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to