On 9/4/24 10:58, Paolo Bonzini wrote:
Il lun 8 apr 2024, 23:34 Philippe Mathieu-Daudé <phi...@linaro.org
<mailto:phi...@linaro.org>> ha scritto:
Note, the QOM type definition is not modified, TYPE_I2C_TARGET
remains defined as "i2c-slave".
Is this actually necessary? The only thing that could break is -global
but I don't think it matters really.
I remembered some discussion with Gerd where he mentioned we can not
rename a QOM type because it is a stable interface (-device TYPE),
but here I missed the type is abstract, so not user-creatable, thus
it is safe to rename.
Consider the following hunk squashed:
-- >8 --
diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h
index abefee78fd..8908267c17 100644
--- a/include/hw/i2c/i2c.h
+++ b/include/hw/i2c/i2c.h
@@ -24 +24 @@ typedef struct I2CNodeList I2CNodeList;
-#define TYPE_I2C_TARGET "i2c-slave"
+#define TYPE_I2C_TARGET "i2c-target"
---
Paolo
[*]
https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
<https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md>
Inspired-by: Wolfram Sang <wsa+rene...@sang-engineering.com
<mailto:wsa%2brene...@sang-engineering.com>>
Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org
<mailto:phi...@linaro.org>>
---
include/hw/display/i2c-ddc.h | 2 +-
include/hw/gpio/pca9552.h | 2 +-
include/hw/gpio/pca9554.h | 2 +-
include/hw/i2c/aspeed_i2c.h | 4 +-
include/hw/i2c/i2c.h | 66 ++++-----
include/hw/i2c/i2c_mux_pca954x.h | 2 +-
include/hw/i2c/smbus_slave.h | 4 +-
include/hw/nvram/eeprom_at24c.h | 4 +-
include/hw/sensor/tmp105.h | 2 +-
hw/arm/aspeed.c | 232 +++++++++++++++----------------
hw/arm/bananapi_m2u.c | 2 +-
hw/arm/cubieboard.c | 2 +-
hw/arm/musicpal.c | 6 +-
hw/arm/npcm7xx_boards.c | 44 +++---
hw/arm/nseries.c | 6 +-
hw/arm/pxa2xx.c | 36 ++---
hw/arm/realview.c | 2 +-
hw/arm/spitz.c | 12 +-
hw/arm/stellaris.c | 2 +-
hw/arm/tosa.c | 14 +-
hw/arm/versatilepb.c | 2 +-
hw/arm/vexpress.c | 2 +-
hw/arm/z2.c | 20 +--
hw/audio/wm8750.c | 18 +--
hw/display/ati.c | 4 +-
hw/display/i2c-ddc.c | 10 +-
hw/display/sii9022.c | 16 +--
hw/display/sm501.c | 2 +-
hw/display/ssd0303.c | 14 +-
hw/display/xlnx_dp.c | 2 +-
hw/gpio/max7310.c | 14 +-
hw/gpio/pca9552.c | 14 +-
hw/gpio/pca9554.c | 14 +-
hw/gpio/pcf8574.c | 12 +-
hw/i2c/aspeed_i2c.c | 16 +--
hw/i2c/core.c | 88 ++++++------
hw/i2c/i2c_mux_pca954x.c | 6 +-
hw/i2c/imx_i2c.c | 2 +-
hw/i2c/smbus_slave.c | 12 +-
hw/input/lm832x.c | 14 +-
hw/misc/axp2xx.c | 14 +-
hw/misc/i2c-echo.c | 14 +-
hw/nvram/eeprom_at24c.c | 22 +--
hw/ppc/e500.c | 2 +-
hw/ppc/pnv.c | 4 +-
hw/ppc/sam460ex.c | 2 +-
hw/rtc/ds1338.c | 14 +-
hw/rtc/m41t80.c | 12 +-
hw/rtc/twl92230.c | 16 +--
hw/sensor/dps310.c | 14 +-
hw/sensor/emc141x.c | 16 +--
hw/sensor/lsm303dlhc_mag.c | 16 +--
hw/sensor/tmp105.c | 16 +--
hw/sensor/tmp421.c | 20 +--
hw/tpm/tpm_tis_i2c.c | 12 +-
55 files changed, 461 insertions(+), 461 deletions(-)
