Hi On Wed, Apr 10, 2024 at 2:06 PM ゞlym <707242...@qq.com> wrote: > >
Please send the patch as inline: https://www.qemu.org/docs/master/devel/submitting-a-patch.html#do-not-send-as-an-attachment The patch is doing too much changes to the ssd.lock usage without explaining in detail which race and how it solved it. In particular, ui/spice-display.c usage seems safer before your change, since it takes the lock on display_refresh and display_mouse_define. It properly temporarily releases the lock before calling the dpy_mouse_set() and dpy_cursor_define() as well. To me, it looks like the only offender is qxl_spice_reset_cursor(), which lacks locking before unrefing. Could you confirm this hypothesis if you are able to reproduce the issue? thanks
