On 4/12/24 09:08, Peter Maydell wrote:
The npcm7xx_clk and npcm7xx_gcr device reset methods look at
the ResetType argument and only handle RESET_TYPE_COLD,
producing a warning if another reset type is passed. This
is different from how every other three-phase-reset method
we have works, and makes it difficult to add new reset types.
A better pattern is "assume that any reset type you don't know
about should be handled like RESET_TYPE_COLD"; switch these
devices to do that. Then adding a new reset type will only
need to touch those devices where its behaviour really needs
to be different from the standard cold reset.
Signed-off-by: Peter Maydell<peter.mayd...@linaro.org>
---
hw/misc/npcm7xx_clk.c | 13 +++----------
hw/misc/npcm7xx_gcr.c | 12 ++++--------
2 files changed, 7 insertions(+), 18 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
