On 15 March 2012 07:35, Igor Mitsyanko <i.mitsya...@samsung.com> wrote: > Create 9 exynos4210 i2c interfaces. > > Signed-off-by: Igor Mitsyanko <i.mitsya...@samsung.com>
Mostly this looks OK but I still find the i2c slave stuff odd -- should the controller really register itself as a slave on its own bus? Doesn't this mean that the controller can effectively try to talk to itself? Does the hardware let you do that? I suspect that what's happening here is that the hardware lets you put the i2c controller into slave mode so some other device on the bus can be a master. But QEMU's i2c bus abstraction doesn't cover that use case at all... Anyway, I don't know enough about i2c to really be able to review this patch properly in that area. Anybody? -- PMM
