Hi Philippe, On Thu, Apr 18, 2024 at 02:06:15PM +0200, Philippe Mathieu-Daudé wrote:
[snip] > > diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h > > index 5012fab6f763..945ee6ffd045 100644 > > --- a/include/hw/cxl/cxl_component.h > > +++ b/include/hw/cxl/cxl_component.h > > @@ -273,7 +273,7 @@ hwaddr cxl_decode_ig(int ig); > > CXLComponentState *cxl_get_hb_cstate(PCIHostState *hb); > > bool cxl_get_hb_passthrough(PCIHostState *hb); > > -void cxl_doe_cdat_init(CXLComponentState *cxl_cstate, Error **errp); > > +bool cxl_doe_cdat_init(CXLComponentState *cxl_cstate, Error **errp); > > void cxl_doe_cdat_release(CXLComponentState *cxl_cstate); > > void cxl_doe_cdat_update(CXLComponentState *cxl_cstate, Error **errp); > > Another candidate ;) > I guess you mean cxl_doe_cdat_update()? ;-) It's a special case since it has only one use case and in that case, &error_fatal is passed as @errp. So then it doesn't need to check the return value. Thanks, Zhao
