Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> writes:
> Now we do set MIGRATION_FAILED state, but don't give a chance to
> orchestrator to query migration state and get the error.
>
> Let's provide a possibility for QMP-based orchestrators to get an error
> like with outgoing migration.
>
> For hmp_migrate_incoming(), let's enable the new behavior: HMP is not
> and ABI, it's mostly intended to use by developer and it makes sense
> not to stop the process.
>
> For x-exit-preconfig, let's keep the old behavior:
> - it's called from init(), so here we want to keep current behavior by
> default
> - it does exit on error by itself as well
> So, if we want to change the behavior of x-exit-preconfig, it should be
> another patch.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 8c65b90328..9de8b98d0b 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1837,6 +1837,10 @@
> # @channels: list of migration stream channels with each stream in the
> # list connected to a destination interface endpoint.
> #
> +# @exit-on-error: Do exit on incoming migration failure. Default true.
Scratch "Do"?
> +# When set to false, the error is reported by MIGRATION event and
Comma before "and", please.
Suggest "the failure triggers a MIGRATION event".
> +# error could be retrieved by query-migrate command. (since 9.1)
"error details could be retrieved with query-migrate", perhaps?
> +#
> # Since: 2.3
> #
> # Notes:
> @@ -1889,7 +1893,8 @@
> ##
> { 'command': 'migrate-incoming',
> 'data': {'*uri': 'str',
> - '*channels': [ 'MigrationChannel' ] } }
> + '*channels': [ 'MigrationChannel' ],
> + '*exit-on-error': 'bool' } }
>
> ##
> # @xen-save-devices-state:
QAPI schema
Acked-by: Markus Armbruster <arm...@redhat.com>
[...]
