On Wed, Mar 21, 2012 at 4:17 PM, Stefan Weil <s...@weilnetz.de> wrote: > Am 12.03.2012 09:32, schrieb Jia Liu: > >> >> This patch is the helper define of MIPS ASE DSP. >> >> Signed-off-by: Jia Liu <pro...@gmail.com> >> --- >> target-mips/helper.h | 152 >> ++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 files changed, 152 insertions(+), 0 deletions(-) >> >> diff --git a/target-mips/helper.h b/target-mips/helper.h >> index 442f684..1abf582 100644 >> --- a/target-mips/helper.h >> +++ b/target-mips/helper.h >> @@ -297,4 +297,156 @@ DEF_HELPER_0(rdhwr_ccres, tl) >> DEF_HELPER_1(pmon, void, int) >> DEF_HELPER_0(wait, void) >> >> +/* MIPS32 DSP */ >> +DEF_HELPER_1(absqsph, i32, i32) >> +DEF_HELPER_1(absqsw, i32, i32) >> +DEF_HELPER_2(addqph, i32, i32, i32) >> +DEF_HELPER_2(addqsph, i32, i32, i32) > > [snip] > > Hi, > > I know that a lot of people love such tabulated code, but I personally > would prefer to see those DEF_HELPER lines using the style which > is used in the existing code (one space after comma). >
Hi Stefan, Thank you for review. I've fixed it, addressed your comments. Regards, Jia. > Regards, > Stefan Weil >
