On 30/4/24 17:06, Bernhard Beschow wrote:
Fix the leaking in x86_bios_rom_init() by adding a "bios" attribute to X86MachineState. Note that it is only used in the -bios case.Signed-off-by: Bernhard Beschow <shen...@gmail.com> --- include/hw/i386/x86.h | 1 + hw/i386/x86.c | 13 ++++++------- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h index 271ad50470..fb41263b9d 100644 --- a/include/hw/i386/x86.h +++ b/include/hw/i386/x86.h @@ -52,6 +52,7 @@ struct X86MachineState { DeviceState *ioapic2; GMappedFile *initrd_mapped_file; HotplugHandler *acpi_dev; + MemoryRegion bios; MemoryRegion isa_bios;
Do you mind describing what is each in a small comment? Otherwise, Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
