Re: [PATCH V1 18/26] migration: cpr-exec-args parameter

[Steven Sistare]

On 5/2/2024 8:23 AM, Markus Armbruster wrote:

Steve Sistare <steven.sist...@oracle.com> writes:

Create the cpr-exec-args migration parameter, defined as a list of
strings.  It will be used for cpr-exec migration mode in a subsequent
patch.

No functional change, except that cpr-exec-args is shown by the
'info migrate' command.

Signed-off-by: Steve Sistare <steven.sist...@oracle.com>

[...]

diff --git a/qapi/migration.json b/qapi/migration.json
index 8c65b90..49710e7 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -914,6 +914,9 @@
  #     See description in @ZeroPageDetection.  Default is 'multifd'.
  #     (since 9.0)
  #
+# @cpr-exec-args: Arguments passed to new QEMU for @cpr-exec mode.
+#    See @cpr-exec for details.  (Since 9.1)
+#

You mean migration mode @cpr-exec, don't you?

If yes, dangling reference until PATCH 20 adds it.  Okay, but worth a
mention in the commit message.

Suggest "See MigMode @cpr-exec for details."

Yes to all.  Will update as you suggest.

- Steve

  # Features:
  #
  # @deprecated: Member @block-incremental is deprecated.  Use
@@ -948,7 +951,8 @@
             { 'name': 'x-vcpu-dirty-limit-period', 'features': ['unstable'] },
             'vcpu-dirty-limit',
             'mode',
-           'zero-page-detection'] }
+           'zero-page-detection',
+           'cpr-exec-args'] }

##

  # @MigrateSetParameters:
@@ -1122,6 +1126,9 @@
  #     See description in @ZeroPageDetection.  Default is 'multifd'.
  #     (since 9.0)
  #
+# @cpr-exec-args: Arguments passed to new QEMU for @cpr-exec mode.
+#    See @cpr-exec for details.  (Since 9.1)
+#
  # Features:
  #
  # @deprecated: Member @block-incremental is deprecated.  Use
@@ -1176,7 +1183,8 @@
                                              'features': [ 'unstable' ] },
              '*vcpu-dirty-limit': 'uint64',
              '*mode': 'MigMode',
-            '*zero-page-detection': 'ZeroPageDetection'} }
+            '*zero-page-detection': 'ZeroPageDetection',
+            '*cpr-exec-args': [ 'str' ]} }

##

  # @migrate-set-parameters:
@@ -1354,6 +1362,9 @@
  #     See description in @ZeroPageDetection.  Default is 'multifd'.
  #     (since 9.0)
  #
+# @cpr-exec-args: Arguments passed to new QEMU for @cpr-exec mode.
+#    See @cpr-exec for details.  (Since 9.1)
+#
  # Features:
  #
  # @deprecated: Member @block-incremental is deprecated.  Use
@@ -1405,7 +1416,8 @@
                                              'features': [ 'unstable' ] },
              '*vcpu-dirty-limit': 'uint64',
              '*mode': 'MigMode',
-            '*zero-page-detection': 'ZeroPageDetection'} }
+            '*zero-page-detection': 'ZeroPageDetection',
+            '*cpr-exec-args': [ 'str' ]} }

##

  # @query-migrate-parameters: