Hi Marc-André,
> -----Original Message-----
> From: Marc-André Lureau <marcandre.lur...@gmail.com>
> Sent: Tuesday, May 7, 2024 8:10 AM
> To: Kim, Dongwon <dongwon....@intel.com>
> Cc: qemu-devel@nongnu.org; kra...@redhat.com
> Subject: Re: [PATCH] ui/gtk: Explicitly set the default size of new window
> when
> untabifying
>
> Hi
>
> On Wed, May 1, 2024 at 7:47 AM <dongwon....@intel.com> wrote:
> >
> > From: Dongwon Kim <dongwon....@intel.com>
> >
> > When untabifying, the default size of the new window was inadvertently
> > set to the size smaller than quarter of the primary window size due to
> > lack of explicit configuration. This commit addresses the issue by
> > ensuring that the size of untabified windows is set to match the
> > surface size.
>
> From a quick test, I don't see a difference of behaviour after the patch.
> Could
> you help me reproduce the issue?
>
> I also don't think it is correct for two reasons:
> - the inner display widget should cause a window size reconfiguration
> - the window size != display size
[Kim, Dongwon] Ok, I see this is happening only when virtio-vga device is used
like
qemu-system-x86_64 -m 2048 -enable-kvm -cpu host -smp cores=2 -drive
file=./OVMF.fd,format=raw,if=pflash -device virtio-vga -display gtk,gl=on
Maybe some setting of dimensions is missing in there? I will take a look.
>
> thanks
>
> > Cc: Gerd Hoffmann <kra...@redhat.com>
> > Cc: Marc-André Lureau <marcandre.lur...@redhat.com>
> > Cc: Vivek Kasireddy <vivek.kasire...@intel.com>
> > Signed-off-by: Dongwon Kim <dongwon....@intel.com>
> > ---
> > ui/gtk.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/ui/gtk.c b/ui/gtk.c
> > index 810d7fc796..269b8207d7 100644
> > --- a/ui/gtk.c
> > +++ b/ui/gtk.c
> > @@ -1395,6 +1395,9 @@ static void gd_menu_untabify(GtkMenuItem *item,
> void *opaque)
> > if (!vc->window) {
> > gtk_widget_set_sensitive(vc->menu_item, false);
> > vc->window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
> > + gtk_window_set_default_size(GTK_WINDOW(vc->window),
> > + surface_width(vc->gfx.ds),
> > + surface_height(vc->gfx.ds));
> > #if defined(CONFIG_OPENGL)
> > if (vc->gfx.esurface) {
> > eglDestroySurface(qemu_egl_display, vc->gfx.esurface);
> > --
> > 2.34.1
> >
> >
>
>
> --
> Marc-André Lureau
