On Tue May 7, 2024 at 10:31 PM AEST, BALATON Zoltan wrote: > On Tue, 7 May 2024, Nicholas Piggin wrote: > > What do you think about adding mmu-book3e.c instead? > > I have considered that but found that some functions have to be in the > same file and declared static for the compiler to inline them otherwise I > get worse performance. Maybe after these rearrangments it's now possible > to move these out but as this series got a bit long already I dod not go > through with that and left it for a follow up but I can give it a try.
It would be nice. What host machines are you using? I'm surprised inlining is causing so much performance unless it is something older or in-order. Should be able to move small common things inline to headers if it's important though, we should try to split since you've done most of the work now. Thanks, Nick > > Thanks for the review so far, I'll try to make the changes that I > understood and submit and updated version. I'm not sure I got some of your > requests so that may need another round. > > Regards, > BALATON Zoltan
