On Fri, 23 Mar 2012 14:11:53 -0500 Michael Roth <mdr...@linux.vnet.ibm.com> wrote:
> On Fri, Mar 23, 2012 at 03:20:22PM -0300, Luiz Capitulino wrote: > > On Tue, 20 Mar 2012 19:54:09 -0500 > > Michael Roth <mdr...@linux.vnet.ibm.com> wrote: > > > > > This currently breaks the build for BSDs. > > > > > > Signed-off-by: Michael Roth <mdr...@linux.vnet.ibm.com> > > > --- > > > qga/commands-posix.c | 22 ++++++++++++++++++++++ > > > 1 files changed, 22 insertions(+), 0 deletions(-) > > > > > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > > > index 89dde92..16737d7 100644 > > > --- a/qga/commands-posix.c > > > +++ b/qga/commands-posix.c > > > @@ -24,10 +24,12 @@ > > > > > > #include <sys/types.h> > > > #include <sys/ioctl.h> > > > +#if defined(__linux__) > > > #include <ifaddrs.h> > > > #include <arpa/inet.h> > > > #include <sys/socket.h> > > > #include <net/if.h> > > > +#endif > > > #include <sys/wait.h> > > > #include "qga/guest-agent-core.h" > > > #include "qga-qmp-commands.h" > > > @@ -542,6 +544,7 @@ int64_t qmp_guest_fsfreeze_thaw(Error **err) > > > #define SUSPEND_SUPPORTED 0 > > > #define SUSPEND_NOT_SUPPORTED 1 > > > > Missing the macros and I think reopen_fd_to_null() is missing too, also > > doesn't apply to latest master. > > > > Shouldn't hurt, but yah, leaving them in is a bit sloppy. I think letting reopen_fd_to_null() out won't actually build. > Don't see why this wouldn't apply though... are you applying on top of > Michal's patch? Oh, no, I was trying to apply on master to test it... If Michal's patch is not applied yet, then I think you should post a version that applies on master and Michal should rebase on top of your patch. > This patch was meant to be the guest-suspend counterpart > rather than a standalone fix. Yeah, I missed it. I'm sorry for that and thanks for fixing it!