Hi Rayhan, On 10/5/24 16:10, Rayhan Faizel wrote:
Signed-off-by: Rayhan Faizel <rayhan.fai...@gmail.com> --- hw/arm/bcm2835_peripherals.c | 13 ++++++++++++- include/hw/arm/bcm2835_peripherals.h | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-)
@@ -500,7 +512,6 @@ void bcm_soc_peripherals_common_realize(DeviceState *dev, Error **errp) create_unimp(s, &s->i2s, "bcm2835-i2s", I2S_OFFSET, 0x100); create_unimp(s, &s->smi, "bcm2835-smi", SMI_OFFSET, 0x100); create_unimp(s, &s->bscsl, "bcm2835-spis", BSC_SL_OFFSET, 0x100); - create_unimp(s, &s->otp, "bcm2835-otp", OTP_OFFSET, 0x80);
Maybe worth noting in the description, before we were covering a range of 0x80 and now 0x28, so a range of 0x58 I/O ends in RAM. Maybe better keep a region of 0x80 in the previous patch? Flatview diff: (qemu) info mtree -f FlatView #0 AS "memory", root: system Root memory region: system 0000000000000000-000000003f002fff (prio 0, ram): ram ... - 000000003f20f000-000000003f20f07f (prio -1000, i/o): bcm2835-otp - 000000003f20f080-000000003f211fff (prio 0, ram): ram @000000003f20f080 + 000000003f20f000-000000003f20f027 (prio 0, i/o): bcm2835-otp + 000000003f20f028-000000003f211fff (prio 0, ram): ram @000000003f20f028 FlatView #3 Root memory region: bcm2835-gpu 0000000000000000-000000003fffffff (prio 0, ram): ram 0000000040000000-000000007e002fff (prio 0, ram): ram ... - 000000007e20f000-000000007e20f07f (prio -1000, i/o): bcm2835-otp - 000000007e20f080-000000007e211fff (prio 0, ram): ram @000000003e20f080 + 000000007e20f000-000000007e20f027 (prio 0, i/o): bcm2835-otp + 000000007e20f028-000000007e211fff (prio 0, ram): ram @000000003e20f028
create_unimp(s, &s->dbus, "bcm2835-dbus", DBUS_OFFSET, 0x8000); create_unimp(s, &s->ave0, "bcm2835-ave0", AVE0_OFFSET, 0x8000); create_unimp(s, &s->v3d, "bcm2835-v3d", V3D_OFFSET, 0x1000);