On Mon, May 13, 2024 at 04:22:00PM +0200, Thomas Huth wrote: > On 13/05/2024 14.11, Daniel P. Berrangé wrote: > > On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: > > > On 13/05/2024 12.28, Daniel P. Berrangé wrote: > > > > A better way to handle this would be to define a separate project > > > > > > > > 'tests/lcitool/projects/qemu-win-installer.yml' > > > > > > > > With > > > > > > > > packages > > > > - g++ > > > > > > > > Then enable the extra project for win64 > > > > > > > > generate_dockerfile("fedora-win64-cross", "fedora-38", > > > > project='qemu,qemu-win-installer', > > > > cross="mingw64", > > > > trailer=cross_build("x86_64-w64-mingw32-", > > > > "x86_64-softmmu")) > > > > > > > > which should result in an identical container to what we have today > > > > for win64, while letting us slim the other containers. > > > > > > Ok, good idea! ... but then we need to teach lcitool about mingw-w64-tools > > > first, otherwise that vss code won't get built due to the missing "widl" > > > tool. > > > > Why is that a pre-requisite ? What i've suggested will result in a > > Dockerfile for win64 that is 100% identical to what we already have > > in git today. So surely that will already succeed to the same extent > > that CI succeeds today ? > > If you want to have the same result, we can also simply remove g++ > everywhere, also for the mingw cross containers, since the vss code is > currently not built at all due to the missing widl program.
Oh, I'm getting mixed up between the qemu-setup.exe and the qga installer exe. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|