On 5/14/24 16:37, Helge Deller wrote:
* Richard Henderson <richard.hender...@linaro.org>:
Add a common routine for writing the return address.
Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
Reviewed-by: Helge Deller <del...@gmx.de>
---
target/hppa/translate.c | 54 +++++++++++++++++++++++------------------
1 file changed, 31 insertions(+), 23 deletions(-)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 08d5e2a4bc..f816b337ee 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -634,6 +634,23 @@ static void install_iaq_entries(DisasContext *ctx,
uint64_t bi, TCGv_i64 bv,
}
}
+static void install_link(DisasContext *ctx, unsigned link, bool with_sr0)
+{
+ tcg_debug_assert(ctx->null_cond.c == TCG_COND_NEVER);
+ if (link) {
Just wondering:
Doesn't it makes it easier to write here:
if (!link) {
return;
}
and then don't indent the few following lines?
I see you change and partly revert it again in patch #17...
so forget this remark for now.
Helge
