On 5/13/24 12:20, Akihiko Odaki wrote:
...
>> -int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g)
>> +static void virtio_gpu_virgl_add_capset(GArray *capset_ids, uint32_t
>> capset_id)
>> +{
>> + g_array_append_val(capset_ids, capset_id);
>> +}
>
> Is it worthwhile to have a function for this?
It's necessary to have it because g_array_append_val() is actually a macro that
takes &capset_id ptr internally.
I.e. g_array_append_val(capset_ids, VIRTIO_GPU_CAPSET_VIRGL2) will fail to
compile with:
/usr/include/glib-2.0/glib/garray.h:66:59: error: lvalue required as unary '&'
operand
66 | #define g_array_append_val(a,v) g_array_append_vals (a, &(v), 1)
--
Best regards,
Dmitry
