On Thu, 16 May 2024 at 10:12, Song Gao <gaos...@loongson.cn> wrote: > > From: Bibo Mao <maob...@loongson.cn> > > Since migration test case requires compat machine type support, > compat machine is added for qemu 9.1 here.
This is not a good justification for adding versioned machine types. Adding versioned machine types is putting a massive maintenance burden on yourself from now onward: * every release needs a new machine type adding * every change to the board model or to any devices it uses needs to be assessed for cross-version compatibility issues, and if necessary extra properties must be added so old versions of the board model keep the legacy backwards-compatible behaviour * migration compatibility must be maintained You really do not want to do this until you decide that your architecture and machine type are at a level where this is a support guarantee you want to provide to users. "It lets us run a test case" is not a good reason to do it, and I strongly recommend you do not add versioned machine types just for that. thanks -- PMM
