Hi, Am 03.05.24 um 14:34 schrieb Philippe Mathieu-Daudé: > In commit bb6cf6f016 ("accel/tcg: Factor tcg_cpu_reset_hold() out") > we unfortunately restricted the tcg_flush_jmp_cache() to system > emulation. Move it to the common tcg_exec_cpu_reset_hold() handler > so user emulation gets the jmp_cache initialized when threads > are created. > > Remove the NULL check in tcg_flush_jmp_cache() from commit 4e4fa6c12d > ("accel/tcg: Complete cpu initialization before registration") which > was a band-aid fix for incorrect commit bb6cf6f016. >
AFAICT, commit 4e4fa6c12d was already present in v7.2.0, while commit bb6cf6f016 only later in v8.2.0. So is it really fine to remove the NULL check? Best Regards, Fiona