>-----Original Message----- >From: Jason Wang <jasow...@redhat.com> >Sent: Monday, May 20, 2024 8:44 AM >To: Duan, Zhenzhong <zhenzhong.d...@intel.com> >Cc: qemu-devel@nongnu.org; Liu, Yi L <yi.l....@intel.com>; Peng, Chao P ><chao.p.p...@intel.com>; Yu Zhang <yu.c.zh...@linux.intel.com>; Michael >S. Tsirkin <m...@redhat.com>; Paolo Bonzini <pbonz...@redhat.com>; >Richard Henderson <richard.hender...@linaro.org>; Eduardo Habkost ><edua...@habkost.net>; Marcel Apfelbaum <marcel.apfelb...@gmail.com> >Subject: Re: [PATCH] intel_iommu: Use the latest fault reasons defined by >spec > >On Fri, May 17, 2024 at 6:26 PM Zhenzhong Duan ><zhenzhong.d...@intel.com> wrote: >> >> From: Yu Zhang <yu.c.zh...@linux.intel.com> >> >> Currently we use only VTD_FR_PASID_TABLE_INV as fault reason. >> Update with more detailed fault reasons listed in VT-d spec 7.2.3. >> >> Signed-off-by: Yu Zhang <yu.c.zh...@linux.intel.com> >> Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com> >> --- > >I wonder if this could be noticed by the guest or not. If yes should >we consider starting to add thing like version to vtd emulation code?
Kernel only dumps the reason like below: DMAR: [DMA Write NO_PASID] Request device [20:00.0] fault addr 0x1234600000 [fault reason 0x71] SM: Present bit in first-level paging entry is clear Maybe bump 1.0 -> 1.1? My understanding version number is only informational and is far from accurate to mark if a feature supported. Driver should check cap/ecap bits instead. Thanks Zhenzhong