Re: [PATCH v3 2/4] target/hexagon: idef-parser remove undefined functions

[Brian Cain]

On 5/21/2024 3:16 PM, Anton Johansson via wrote:

Signed-off-by: Anton Johansson <a...@rev.ng>
Reviewed-by: Taylor Simpson <ltaylorsimp...@gmail.com>
---

Reviewed-by: Brian Cain <bc...@quicinc.com>

  target/hexagon/idef-parser/parser-helpers.h | 13 -------------
  1 file changed, 13 deletions(-)

diff --git a/target/hexagon/idef-parser/parser-helpers.h 
b/target/hexagon/idef-parser/parser-helpers.h
index 7c58087169..2087d534a9 100644
--- a/target/hexagon/idef-parser/parser-helpers.h
+++ b/target/hexagon/idef-parser/parser-helpers.h
@@ -143,8 +143,6 @@ void commit(Context *c);

#define OUT(c, locp, ...) FOR_EACH((c), (locp), OUT_IMPL, __VA_ARGS__) -const char *cmp_swap(Context *c, YYLTYPE *locp, const char *type);

-
  /**
   * Temporary values creation
   */
@@ -236,8 +234,6 @@ HexValue gen_extract_op(Context *c,
                          HexValue *index,
                          HexExtract *extract);

-HexValue gen_read_reg(Context *c, YYLTYPE *locp, HexValue *reg);

-
  void gen_write_reg(Context *c, YYLTYPE *locp, HexValue *reg, HexValue *value);

void gen_assign(Context *c,

@@ -274,13 +270,6 @@ HexValue gen_ctpop_op(Context *c, YYLTYPE *locp, HexValue 
*src);

HexValue gen_rotl(Context *c, YYLTYPE *locp, HexValue *src, HexValue *n); -HexValue gen_deinterleave(Context *c, YYLTYPE *locp, HexValue *mixed);

-
-HexValue gen_interleave(Context *c,
-                        YYLTYPE *locp,
-                        HexValue *odd,
-                        HexValue *even);
-
  HexValue gen_carry_from_add(Context *c,
                              YYLTYPE *locp,
                              HexValue *op1,
@@ -349,8 +338,6 @@ HexValue gen_rvalue_ternary(Context *c, YYLTYPE *locp, 
HexValue *cond,

const char *cond_to_str(TCGCond cond); -void emit_header(Context *c);

-
  void emit_arg(Context *c, YYLTYPE *locp, HexValue *arg);

void emit_footer(Context *c);