Re: [PATCH v2 20/20] vfio/ccw: Fix the missed unrealize() call in error path

[Cédric Le Goater]

On 5/22/24 06:40, Zhenzhong Duan wrote:
When get name failed, we should call unrealize() so that
vfio_ccw_realize() is self contained.
Fixes: 909a6254eda ("vfio/ccw: Make vfio cdev pre-openable by passing a file 
handle")
Signed-off-by: Zhenzhong Duan <zhenzhong.d...@intel.com>

If the realize handler fails, the unrealize handler should be called.
See device_set_realized(). We should be fine without IMO.


Thanks,

C.


 
---
  hw/vfio/ccw.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index 168c9e5973..161704cd7b 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -589,7 +589,7 @@ static void vfio_ccw_realize(DeviceState *dev, Error **errp)
      }
  
      if (!vfio_device_get_name(vbasedev, errp)) {
-        return;
+        goto out_unrealize;
      }
  
      if (!vfio_attach_device(cdev->mdevid, vbasedev,
@@ -633,6 +633,7 @@ out_region_err:
      vfio_detach_device(vbasedev);
  out_attach_dev_err:
      g_free(vbasedev->name);
+out_unrealize:
      if (cdc->unrealize) {
          cdc->unrealize(cdev);
      }