On 5/22/24 05:39, Paolo Bonzini wrote:
gen_rot_carry and gen_rot_overflow are meant to be called with count == NULL
if the count cannot be zero. However this is not done in gen_ROL and gen_ROR,
and writing everywhere "can_be_zero ? count : NULL" is burdensome and less
readable. Just pass can_be_zero as a separate argument.
gen_RCL and gen_RCR use a conditional branch to skip the computation
if count is zero, so they can pass false unconditionally to gen_rot_overflow.
Signed-off-by: Paolo Bonzini<pbonz...@redhat.com>
---
target/i386/tcg/emit.c.inc | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
r~
