The compilation error caused by attempting of use 128 bit '__sync_val_compare_and_swap_16', which is supported on the host but not enabled, I don't think this is expected behavior.
Also the patch is little incomplete, I already sent v2 patch, that applying the flag only for x86_64 host. With regards, Artyom K. ________________________________ From: Daniel P. Berrangé <berra...@redhat.com> Sent: Thursday, May 23, 2024 11:02:31 AM To: Artyom Kunakovsky <artyomkunakov...@gmail.com> Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org> Subject: Re: [PATCH] meson.build: add -mcx16 flag On Wed, May 22, 2024 at 10:30:16PM +0300, Artyom Kunakovsky wrote: > fix linker error if the project was configured by the './configure > --cpu=unknown --target-list=riscv64-softmmu' command Isn't this simply user error, with the right answer being to pass a valid CPU target to --cpu, rather than "unknown" > > Signed-off-by: Artyom Kunakovsky <artyomkunakov...@gmail.com> > --- > meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
