On 24-05-28 10:00:35, Jeuk Kim wrote:
> Thanks for your contribution!
>
> There are only two minor comments.
Thanks for your review.
>
> Please check it and send patch v2.
>
>
> Thank you!
>
> On 5/21/2024 8:05 PM, Minwoo Im wrote:
> > @@ -1288,12 +1717,21 @@ static void ufs_exit(PCIDevice *pci_dev)
> > ufs_clear_req(&u->req_list[i]);
> > }
> > g_free(u->req_list);
> > +
> > + for (int i = 0; i < ARRAY_SIZE(u->sq); i++) {
> > + ufs_mcq_delete_sq(u, i);
>
> Isn't it possible that trace_ufs_err_mcq_delete_cq_not_exists is printed
> even in a normal shutdown situation?
>
> If true, please fix it so that the ufs_err log is not printed in normal
> situation.
I will make sure that the normal shut-down case will not print out the error
event trace.
>
> > + }
> > + for (int i = 0; i < ARRAY_SIZE(u->cq); i++) {
> > + ufs_mcq_delete_cq(u, i);
> > + }
> > }
> > static Property ufs_props[] = {
> > DEFINE_PROP_STRING("serial", UfsHc, params.serial),
> > DEFINE_PROP_UINT8("nutrs", UfsHc, params.nutrs, 32),
> > DEFINE_PROP_UINT8("nutmrs", UfsHc, params.nutmrs, 8),
> > + DEFINE_PROP_BOOL("mcq", UfsHc, params.mcq, false),
> > + DEFINE_PROP_UINT8("mcq-maxq", UfsHc, params.mcq_maxq, 1),
> Please change this value to a value greater than or equal to 2.
Oh yeah, it should be to support device command handling in MCQ mode. I will
update it in v2.
