On 30/5/24 08:02, Paolo Bonzini wrote:
On Wed, May 29, 2024 at 5:56 PM Philippe Mathieu-Daudé
<phi...@linaro.org> wrote:
It is pointless to build semihosting when TCG is not available.

Why? I would have naively assumed that a suitable semihosting API
could be implemented by KVM. The justification (and thus the commit
message) needs to be different for each architecture if it's a matter
of instruction set or insufficient KVM userspace API.

I wasn't sure where semihosting could be used so asked on IRC and
Alex told me TCG only. Maybe the current implementation is TCG
only, and I can reword. It certainly need some refactor to work
on KVM, because currently semihosting end calling the TCG probe_access
API, which I'm trying to restrict to TCG in order to ease linking
multiple libtcg for the single binary (see
https://lore.kernel.org/qemu-devel/20240529155918.6221-1-phi...@linaro.org/).

Paolo

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  semihosting/Kconfig | 1 +
  1 file changed, 1 insertion(+)

diff --git a/semihosting/Kconfig b/semihosting/Kconfig
index eaf3a20ef5..fbe6ac87f9 100644
--- a/semihosting/Kconfig
+++ b/semihosting/Kconfig
@@ -1,6 +1,7 @@

  config SEMIHOSTING
         bool
+       depends on TCG

  config ARM_COMPATIBLE_SEMIHOSTING
         bool
--
2.41.0




Reply via email to