On Tue, 30 Apr 2024 at 18:15, Alex Bennée <alex.ben...@linaro.org> wrote:
> The x86 version is essentially being called for side effects. Do we want
> to document this usage in the method?
I plan to take these two patches into target-arm.next, with
a slightly beefed up doc comment:
/**
* @cpu_exec_halt: Callback for handling halt in cpu_exec.
*
* The target CPU should do any special processing here that it needs
* to do when the CPU is in the halted state.
*
* Return true to indicate that the CPU should now leave halt, false
* if it should remain in the halted state.
*
* If this method is not provided, the default is to do nothing, and
* to leave halt if cpu_has_work() returns true.
*/
which hopefully makes it a little clearer to the reader
that "do stuff you need to do when in halt" is the
primary purpose of the method.
I'll do the follow-on tidyup rth suggests once these
have made it into git.
thanks
-- PMM
