On 5/30/24 05:51, Peter Maydell wrote:
@@ -87,13 +87,13 @@ sub progress_update($)
my $barlen = int($proglen * $done / $progmax);
if ($barlen != $lastprog) {
$lastprog = $barlen;
- print "[" . "-" x $barlen . " " x ($proglen - $barlen) . "]\r";
+ print STDOUT "[" . "-" x $barlen . " " x ($proglen - $barlen) . "]\r";
}
}
sub progress_end()
{
- print "[" . "-" x $proglen . "]\n";
+ print STDOUT "[" . "-" x $proglen . "]\n";
$| = 0;
}
These are the progress-bar indicators -- shouldn't they go to STDERR,
not STDOUT, if we're going to be careful about where we send output?
Why? I would think that only errors would go do stderr...
@@ -163,20 +163,20 @@ sub dump_insn_details($$)
{
# Dump the instruction details for one insn
my ($insn, $rec) = @_;
- print "insn $insn: ";
+ print STDOUT "insn $insn: ";
my $insnwidth = $rec->{width};
my $fixedbits = $rec->{fixedbits};
my $fixedbitmask = $rec->{fixedbitmask};
my $constraint = $rec->{blocks}{"constraints"};
- print sprintf(" insnwidth %d fixedbits %08x mask %08x ", $insnwidth,
$fixedbits, $fixedbitmask);
+ print STDOUT sprintf(" insnwidth %d fixedbits %08x mask %08x ",
$insnwidth, $fixedbits, $fixedbitmask);
if (defined $constraint) {
- print "constraint $constraint ";
+ print STDOUT "constraint $constraint ";
}
for my $tuple (@{ $rec->{fields} }) {
my ($var, $pos, $mask) = @$tuple;
- print "($var, $pos, " . sprintf("%08x", $mask) . ") ";
+ print STDOUT "($var, $pos, " . sprintf("%08x", $mask) . ") ";
}
- print "\n";
+ print STDOUT "\n";
}
As a debug-print helper routine maybe this should be STDERR too?
Likewise?
r~